Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] Azure Maps Track2 data-plane onboarding #15151

Closed
wants to merge 18 commits into from
Closed

[maps] Azure Maps Track2 data-plane onboarding #15151

wants to merge 18 commits into from

Conversation

ambientlight
Copy link
Member

@ambientlight ambientlight commented Jul 26, 2021 •
edited
Loading

Initial onboarding of Azure Maps data-plane client libraries (9 clients) following Azure/azure-rest-api-specs#14871

SDK track2 autogen by https://github.com/ambientlight/azure-rest-api-specs/blob/experiment-scripts/gen_go.sh

This PR patches generated files

  1. To alleviate Custom marshalling/unmarshalling is broken for types composed of multiple types autorest.go#652, json Marshall/Unmarshall has been manually fixed all types containing multiple embedded structs at a9720a7 and ada90e7
  2. x-ms-long-running-operations extension does not support custom headers, while Azure Maps AD Authentication requires additional x-ms-client-id header in addition to OAuth2 Bearer auth token, and so additional policy that adds this header to all requests has been injected into all clients via cd951cf and 049a823
  3. OpenAPI 2.0 spec does not support polymorphic parameter types in definition and thus won't go well with generated json parsing, so when json properties of different types are returned, unmarshall will fail, and so type definitions where polymorphic types are occurring has been relaxed to interface{} via 981c73c, 71dd086, 23553ae
  4. Incorrect swagger property definition type(WindDirection) has been fixed to reflect [Maps] [Hub Generated] fix WindDirection incorrect degrees type: int32 -> float in Maps Weather preview/1.0 azure-rest-api-specs#15361 via 30f82eb
  5. VSCode golang plugin also fixed some indentation issues of generated code.

@ambientlight
raw go track2 codegen
d97925c
@ambientlight
manual temp cogen fixes
84c95ca
@ambientlight
--export-clients changes
f6fcfa7
@ambientlight
add shared_key_credential to all client packages
878a016
@ambientlight
missing ResourceLocation assign
78490e3
@ambientlight
add ClientIdCredScaffold to make sure x-ms-client-id added to LRO get…
cd951cf 
… links
@ambientlight
fix json parsing for types with multiple embedded structs of Azure/au…
a9720a7 
…torest.go#652
@ambientlight
featureState value as any
981c73c
@ambientlight
missing json parsing fixes
a841054
@ambientlight
compensate for polymorphic types
71dd086
@ambientlight
xmsClientId dereference fix
a2c44a1
@ambientlight
fix missing xmsClientId in generated creator clients
049a823
@ambientlight
route and search json parsing fixes for types with multiple embeeded …
ada90e7 
…structs of Azure/autorest.go#652
@ambientlight
relax Openlr to polymorphic (can come back as string)
23553ae
@ambientlight
fixes incorrect Degrees type in WindDirection to reflect Azure/azure-…
30f82eb 
…rest-api-specs#15361
@ambientlight
remove redundant entities
3460fee
@ambientlight
add base changelogs
83bbc0f
@ambientlight ambientlight mentioned this pull request Jul 26, 2021
Closed
@check-enforcer
Copy link

This repository is protected by Check Enforcer. The check-enforcer check-run will not pass until there is at least one more check-run successfully passing. Check Enforcer supports the following comment commands:

  • /check-enforcer evaluate; tells Check Enforcer to evaluate this pull request.
  • /check-enforcer override; by-pass Check Enforcer (approvals still required).

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Feb 25, 2022
@ghost
Copy link

ghost commented Feb 25, 2022

Hi @ambientlight. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Mar 4, 2022
@ghost
Copy link

ghost commented Mar 4, 2022

Hi @ambientlight. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

@lirenhe lirenhe Awaiting requested review from lirenhe

Assignees
No one assigned
Labels
no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ambientlight